Skip to content

Commit

Permalink
Merge branch 'main' into ascompleted-future-utility
Browse files Browse the repository at this point in the history
  • Loading branch information
jeanluciano authored Jul 24, 2024
2 parents 700cfa3 + 96fc957 commit 02e3a9d
Show file tree
Hide file tree
Showing 57 changed files with 2,602 additions and 943 deletions.
11 changes: 3 additions & 8 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
# global
* @PrefectHQ/open-source

# backend
/src/prefect/server @PrefectHQ/open-source @zangell44
* @cicdw

# ui
/ui @PrefectHQ/frontend
/ui @znicholasbrown

# documentation
/docs @PrefectHQ/docs
mkdocs.yml @PrefectHQ/docs
mkdocs.insiders.yml @PrefectHQ/docs
/docs @discdiver @daniel-prefect

# imports
/src/prefect/__init__.py @aaazzam @chrisguidry
Expand Down
74 changes: 17 additions & 57 deletions .github/ISSUE_TEMPLATE/1_bug_report.yaml
Original file line number Diff line number Diff line change
@@ -1,20 +1,7 @@
name: 🐛 Bug Report
description: Report a bug or unexpected behavior in Prefect
labels: ["needs:triage", "bug"]
labels: ["bug"]
body:
- type: markdown
attributes:
value: >
Bug reports are often **usage questions, not bugs**. If you do not have a strong understanding
of the interface you are reporting a bug for, please head to our [Community Slack](https://www.prefect.io/slack/)
or [Discourse](https://discourse.prefect.io/) and ask there first. You are likely to get a response
faster and learn more about the feature you're working with. If the issue is determined to be a bug,
we will open an issue here.
GitHub issues raised against this repository will receive community support. If you have an
[active support agreement](https://www.prefect.io/pricing/), we recommend creating a case to ensure
a faster response.
- type: markdown
attributes:
value: >
Expand All @@ -29,56 +16,33 @@ body:
4. Additional details that may help us reproduce your issue.
- type: checkboxes
id: checks
attributes:
label: First check
description: Please confirm and check all the following options.
options:
- label: I added a descriptive title to this issue.
required: true
- label: I used the GitHub search to find a similar issue and didn't find it.
required: true
- label: I searched the Prefect documentation for this issue.
required: true
- label: I checked that this issue is related to Prefect and not one of its dependencies.
required: true
For usage questions, please check out Prefect's [Community Slack](https://www.prefect.io/slack/).
- type: textarea
attributes:
label: Bug summary
description: A clear and concise description of what the bug is.
validations:
required: true
description: A clear and concise description of what the bug is, ideally including [a minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example).
placeholder: >
An explanation of the behavior, along with code that will help others reproduce the issue:
- type: textarea
attributes:
label: Reproduction
description: >
Provide your [minimal, complete, and verifiable](https://stackoverflow.com/help/mcve) example here.
If you need help creating one, you can model yours after the code shared in one of our previous [well written bug reports](https://github.com/PrefectHQ/prefect/issues?q=is%3Aissue+label%3A%22great+writeup%22).
placeholder: "# Insert code here"
render: python3
validations:
required: true
```python
from prefect import flow
@flow
def my_flow():
raise ValueError("This flow misbehaves every time it's run and I don't know why!")
```
Please include tracebacks, console output, etc. with code formatting.
- type: textarea
attributes:
label: Error
description: >
Provide the full exception traceback or console error.
placeholder: "# Copy complete stack trace and error message here, including log or console output if applicable."
render: python3
validations:
required: false
required: true

- type: textarea
attributes:
label: Versions (`prefect version` output)
label: Version info (`prefect version` output)
description: >
Provide information about your Prefect version and environment. The easiest way to retrieve all of the information we require is the `prefect version` command.
If using Prefect 1.x, it is useful to also include the output of `prefect diagnostics`.
**Please do not just include your Prefect version number**. The command provides additional context such as your operating system, Prefect API type, Python version, etc. that we need to diagnose your problem.
Provide information about your Prefect version and environment. The easiest way to retrieve all of this information is by running the `prefect version` command.
placeholder: "# Copy output of the `prefect version` command here. Do not just include your Prefect version number."
render: Text
validations:
Expand All @@ -90,7 +54,3 @@ body:
description: Add any other context about the problem here, including screenshots for UI issues.
validations:
required: false

- type: markdown
attributes:
value: "**Happy engineering!**"
14 changes: 7 additions & 7 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,30 +5,30 @@ updates:
directory: "/"
schedule:
interval: "daily"
labels: ["maintenance"]
labels: ["development"]

- package-ecosystem: "npm"
directory: '/ui/'
schedule:
interval: "weekly"
labels: ["ui", "maintenance"]
labels: ["ui", "development"]

- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
labels: ["maintenance"]
labels: ["development"]

- package-ecosystem: "docker"
directory: "/"
schedule:
interval: "daily"
labels: ["maintenance"]
labels: ["development"]

# Check for Python updates in v1
# Check for Python updates in v2
- package-ecosystem: "pip"
target-branch: "1.x"
target-branch: "2.x"
directory: "/"
schedule:
interval: "daily"
labels: ["maintenance", "v1"]
labels: ["development", "2.x"]
23 changes: 3 additions & 20 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,31 +1,14 @@
<!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
- Confirm that you've done common tasks so we can give a timely review.
- Review our contribution guidelines: https://docs.prefect.io/latest/contributing/overview/
Happy engineering!
Thanks for opening a pull request to Prefect!
If this is your first contribution, please make sure to review our contribution guidelines: https://docs.prefect.io/latest/contributing/overview/
-->

<!-- Include an overview here -->

### Example
<!--
Share an example of the change in action.
A code blurb is best. Changes to features should include an example that is executable by a new user.
If changing documentation, a link to a preview of the page is great.
-->
<!-- Include an overview of the proposed changes here -->

### Checklist
<!-- These boxes may be checked after opening the pull request. -->

- [ ] This pull request includes a label categorizing the change e.g. `maintenance`, `fix`, `feature`, `enhancement`, `docs`.
- [ ] This pull request references any related issue by including "closes `<link to issue>`"
<!-- If you do not have permission to add a label, a maintainer will add one for you -->
- If no issue exists and your change is not a small fix, please [create an issue](https://github.com/PrefectHQ/prefect/issues/new/choose) first.
- [ ] If this pull request adds new functionality, it includes unit tests that cover the changes
- [ ] If this pull request removes docs files, it includes redirect settings in `mint.json`.
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/copy-linked-issue-labels.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: Copy labels from linked issues
on:
pull_request_target:
types: [opened, edited, reopened, ready_for_review, review_requested]

jobs:
copy-labels:
runs-on: ubuntu-latest
name: Copy labels from linked issues
steps:
- name: copy-labels
uses: michalvankodev/[email protected]
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
24 changes: 16 additions & 8 deletions .github/workflows/docker-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,14 @@ on:
- ".github/workflows/docker-images.yaml"
- "ui/**"

# On workflow_dispatch, push sha and branch patterns to prefect-dev
# On workflow_dispatch, allow publishing 3-latest images
workflow_dispatch:
inputs:
publish_3_latest:
description: 'Publish 3-latest images'
required: false
type: boolean
default: false

jobs:
publish-docker-images:
Expand Down Expand Up @@ -97,17 +103,19 @@ jobs:
- name: Generate tags for prefecthq/prefect
id: metadata-prod
uses: docker/metadata-action@v5
# only generate the production tags on release events
if: ${{ github.event_name == 'release' }}
# generate the production tags on release events or when manually triggered for 3-latest
if: ${{ github.event_name == 'release' || (github.event_name == 'workflow_dispatch' && github.event.inputs.publish_3_latest == 'true') }}
with:
images: prefecthq/prefect
# push `latest`, `X.Y` and `X` tags only when the release is not marked as prerelease
# push `latest` and `X` tags only when the release is marked as latest
# push `3-latest` tags on latest release or manual trigger
tags: |
type=pep440,pattern={{version}},suffix=-python${{ matrix.python-version }}${{ matrix.flavor }}
type=pep440,pattern={{major}}.{{minor}},suffix=-python${{ matrix.python-version }}${{ matrix.flavor }},enable=${{ github.event.release.prerelease == false }}
type=pep440,pattern={{major}},suffix=-python${{ matrix.python-version }}${{ matrix.flavor }},enable=${{ github.event.release.prerelease == false && github.ref_name == env.LATEST_TAG }}
type=raw,value=3-latest${{ matrix.flavor }},enable=${{ matrix.python-version == '3.10' && github.event.release.prerelease == false && github.ref_name == env.LATEST_TAG }}
type=pep440,pattern={{version}},suffix=-python${{ matrix.python-version }}${{ matrix.flavor }},enable=${{ github.event_name == 'release' }}
type=pep440,pattern={{major}}.{{minor}},suffix=-python${{ matrix.python-version }}${{ matrix.flavor }},enable=${{ github.event_name == 'release' && github.event.release.prerelease == false }}
type=pep440,pattern={{major}},suffix=-python${{ matrix.python-version }}${{ matrix.flavor }},enable=${{ github.event_name == 'release' && github.event.release.prerelease == false && github.ref_name == env.LATEST_TAG }}
type=raw,value=3-latest${{ matrix.flavor }},enable=${{ (github.event_name == 'release' && github.event.release.prerelease == false && github.ref_name == env.LATEST_TAG && matrix.python-version == '3.12') || (github.event_name == 'workflow_dispatch' && github.event.inputs.publish_3_latest == 'true') }}
type=raw,value=3-latest-python${{ matrix.python-version }}${{ matrix.flavor }},enable=${{ github.event_name == 'workflow_dispatch' && github.event.inputs.publish_3_latest == 'true' }}
flavor: |
latest=false
Expand All @@ -124,4 +132,4 @@ jobs:
labels: ${{ steps.metadata-dev.outputs.labels }}
push: true
pull: true
provenance: false
provenance: false
47 changes: 0 additions & 47 deletions .github/workflows/label-check.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/npm_update_latest_prefect.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
--title "Update @${{ inputs.package_name }} to version ${{ inputs.package_version }}" \
--body "Update @${{ inputs.package_name }} to version ${{ inputs.package_version }}.
Release information can be found at https://github.com/${{ inputs.package_name }}/releases/tag/${{ inputs.package_version }}." \
--label maintenance \
--label development \
--label ui
env:
GITHUB_TOKEN: ${{ secrets.PREFECT_CONTENTS_PR_RW }}
Expand Down
Loading

0 comments on commit 02e3a9d

Please sign in to comment.