Address review comments

PrefectHQ · Sep 9, 2024 · 2c7ea8c · 2c7ea8c
1 parent 9b323be
commit 2c7ea8c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/prefect/client/schemas/objects.py b/src/prefect/client/schemas/objects.py
@@ -306,7 +306,7 @@ def is_cancelling(self) -> bool:
         return self.type == StateType.CANCELLING
 
     def is_cached(self) -> bool:
-        return self.name == "Cached"
+        return self.name == "Cached" and self.type == StateType.COMPLETED
 
     def is_final(self) -> bool:
         return self.type in {

diff --git a/src/prefect/engine.py b/src/prefect/engine.py
@@ -2123,7 +2123,6 @@ async def tick():
     )
 
     if run_on_completion_hooks_on_cached:
-        task_run = await client.read_task_run(task_run.id)
         await _run_task_hooks(
             task=task,
             task_run=task_run,