add tests

src/prefect/events/clients.py

@@ -27,6 +27,7 @@
     ConnectionClosed,
     ConnectionClosedError,
     ConnectionClosedOK,
+    InvalidHandshake,
 )
 from websockets.sync.client import connect as sync_connect
 
@@ -296,23 +297,21 @@ async def __aexit__(
 
     def sync_raise_for_connection_error(self):
         try:
-            with self._sync_connect() as ws:
-                pong = ws.ping()
-                pong.wait()
-        except Exception as e:
+            with self._sync_connect():
+                pass
+        except (OSError, InvalidHandshake, TimeoutError) as e:
             raise RuntimeError(
-                f"Unable to establish connection to {self._events_socket_url!r}. "
+                f"Unable to connect to {self._events_socket_url!r}. "
                 f"Check your network to ensure websocket connections can be made to the API."
             ) from e
 
     async def raise_for_connection_error(self):
         try:
-            async with self._deferred_connect() as ws:
-                pong = ws.ping()
-                await pong
-        except Exception as e:
+            async with self._deferred_connect():
+                pass
+        except (OSError, InvalidHandshake, asyncio.TimeoutError) as e:
             raise RuntimeError(
-                f"Unable to establish connection to {self._events_socket_url!r}. "
+                f"Unable to connect to {self._events_socket_url!r}. "
                 f"Check your network to ensure websocket connections can be made to the API."
             ) from e
 

tests/events/client/test_events_client.py

@@ -82,6 +82,20 @@ async def test_constructs_cloud_client(cloud_settings):
     assert isinstance(get_events_client(), PrefectCloudEventsClient)
 
 
+def test_sync_raise_for_connection_error_bad_url():
+    client = PrefectEventsClient(api_url="http://notarealurl")
+    with pytest.raises(RuntimeError) as e:
+        client.sync_raise_for_connection_error()
+    assert "Unable to connect to 'ws://notarealurl/events/in'" in str(e.value)
+
+
+async def test_raise_for_connection_error_bad_url():
+    client = PrefectEventsClient(api_url="http://notarealurl")
+    with pytest.raises(RuntimeError) as e:
+        await client.raise_for_connection_error()
+    assert "Unable to connect to 'ws://notarealurl/events/in'" in str(e.value)
+
+
 async def test_events_client_can_emit_when_ephemeral_enabled(
     example_event_1: Event, monkeypatch: pytest.MonkeyPatch, ephemeral_settings
 ):