Break TaskRunEngine
into Sync and Async classes
#14643
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to address the issue where the TaskRunEngine is blocking async tasks. The PR fixes this issue by doing a major refactor of
TaskRunEngine
into three parts:A lot of the refactor was also to break apart longer methods, like
setup_run_context
orbegin_run
into component parts that can be used by both the sync and async implementations.Closes #14113