Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split schemas #14644

Closed
wants to merge 9 commits into from
Closed

split schemas #14644

wants to merge 9 commits into from

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Jul 16, 2024

kitchen sink of previous PRs to benchmark

Copy link

codspeed-hq bot commented Jul 16, 2024

CodSpeed Performance Report

Merging #14644 will not alter performance

Comparing split-schemas (fcb2d98) with main (afdb04d)

Summary

✅ 5 untouched benchmarks

@aaazzam
Copy link
Collaborator Author

aaazzam commented Jul 16, 2024

Okay, so tl;dr is we shaved 100ms off of a 1.9s import speed in dev. The tests that are failing is b/c of a long tail of weird object access patterns that should be cleaned up independent of this PR.

I think this is a game of inches, so I'm eager to take a W where we can on this. That said, this moves us to a really gross single-class-per-file pattern that @chrisguidry and I both hate.

@aaazzam aaazzam closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant