Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update task run counts on retry with client-side task orchestration #14706

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jakekaplan
Copy link
Contributor

When moving to a Retrying() state and using client side orchestration, make sure to update the run count. This lets us remove an xfail around an existing test

@jakekaplan jakekaplan requested a review from cicdw as a code owner July 22, 2024 21:56
Copy link

codspeed-hq bot commented Jul 22, 2024

CodSpeed Performance Report

Merging #14706 will not alter performance

Comparing fix-retry-run-counts (25cd0e3) with main (43af48b)

Summary

✅ 5 untouched benchmarks

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cicdw cicdw merged commit 1299f1a into main Jul 22, 2024
34 checks passed
@cicdw cicdw deleted the fix-retry-run-counts branch July 22, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants