Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing of schedules argument in Flow.to_deployment #14711

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

peterbygrave
Copy link
Contributor

@peterbygrave peterbygrave commented Jul 23, 2024

The current typing suggests input should be a list-of-list of schedules, but really should be a list of schedules. The 3 or 4 functions it passes it to expects Optional[FlexibleScheduleList].

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

The current typing suggests input should be a list-of-list of schedules. The 3 or 4 functions it passes it to expects `Optional[FlexibleScheduleList]`.
@peterbygrave peterbygrave requested a review from cicdw as a code owner July 23, 2024 09:44
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye @peterbygrave , thank you!

Copy link

codspeed-hq bot commented Jul 23, 2024

CodSpeed Performance Report

Merging #14711 will not alter performance

Comparing peterbygrave:patch-1 (22f4222) with main (c5f1970)

Summary

✅ 5 untouched benchmarks

@cicdw cicdw merged commit b0231f1 into PrefectHQ:main Jul 23, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants