Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefect.version to event's resource #14713

Closed
wants to merge 2 commits into from
Closed

Add prefect.version to event's resource #14713

wants to merge 2 commits into from

Conversation

jakekaplan
Copy link
Contributor

closes: #14580

Attach prefect.__version__ to all events.

@jakekaplan jakekaplan requested a review from cicdw as a code owner July 23, 2024 15:59
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 23, 2024

CodSpeed Performance Report

Merging #14713 will not alter performance

Comparing add-version-to-events (ce60518) with main (c5f1970)

Summary

✅ 5 untouched benchmarks

@cicdw cicdw requested a review from aaazzam July 23, 2024 16:56
abrookins
abrookins approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like client compat tests need an update, but otherwise, this looks good to me. 👍

@jakekaplan
Copy link
Contributor Author

will re-open once I get tests passing

@jakekaplan jakekaplan closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaazzam aaazzam aaazzam approved these changes

@abrookins abrookins abrookins approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include prefect version as part of the event
3 participants
@jakekaplan @abrookins @aaazzam