-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EventsPipeline
and testing utilities
#14765
Conversation
messages.append(message) | ||
return messages | ||
|
||
async def process_messages(self, messages: List[MemoryMessage]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future when shutting down the ephemeral version we can invoke this method on everything sitting inside of the in-memory events queue
CodSpeed Performance ReportMerging #14765 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits, makes sense to me
Implement the
EventsPipeline
and theevents_pipeline
fixture.With client side task run orchestration,
task-runs
are now eventually consistent. There are a lot of places in our tests where we are reading task runs back from the server to assert something about that finished task run. We still want to support that pattern. To do this, this PR introduces the following:Now you can run the task in your test. And then manually execute a version of the events processes that would normally happen on your sever. In the future
EventsPipeline
can also be used at teardown time of the ephemeral api, so that events and tasks can be recorded.