Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner enforces Deployment.concurrency_limit #15085

Merged

Conversation

jeanluciano
Copy link
Contributor

Ports the changes changes in PR#15022 to the Runner. This let's flows that are deployed by flow.serve or the serve utility, set and use Deployment.concurrency_limit

Related: #14934

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link

codspeed-hq bot commented Aug 27, 2024

CodSpeed Performance Report

Merging #15085 will not alter performance

Comparing jean/oss-85-support-deploymentconcurrency_limit-in-flowserve (7e433f6) with main (6dc401d)

Summary

✅ 3 untouched benchmarks

@abrookins abrookins marked this pull request as ready for review August 28, 2024 00:30
@abrookins abrookins enabled auto-merge (squash) August 28, 2024 00:46
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking pretty good to me! couple comments but i'll defer to @desertaxle on the changes to _submit_run_and_capture_errors

src/prefect/runner/runner.py Outdated Show resolved Hide resolved
src/prefect/runner/runner.py Show resolved Hide resolved
src/prefect/runner/runner.py Outdated Show resolved Hide resolved
src/prefect/runner/runner.py Outdated Show resolved Hide resolved
@jeanluciano jeanluciano self-assigned this Sep 3, 2024
@abrookins abrookins merged commit 746bbe6 into main Sep 9, 2024
31 checks passed
@abrookins abrookins deleted the jean/oss-85-support-deploymentconcurrency_limit-in-flowserve branch September 9, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants