-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Github clone on Windows #15143
Conversation
need to wrap Windows paths with "quotes"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the PR! looks like we need pre-commit run --all-files
here to pass CI
I read and ran the existing tests here. The core functionality of the Github clone command is untested. The tests all mock this away. The functionality of
Because the However, only steps 1 and 3 are actually tested now, and the core purpose of the function, cloning a repo, is untested. That is why the tests pass on Windows, but the module doesn't work in practice. Wrapping the path in quotes very straightforwardly fixes the issue for all OS's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The GitHubRepository.get_directory() method did not work on Windows, because the slashes in the temp path were being removed by shlex. The fix is to wrap the path with "quotes". This is the proposed fix in the issue 13180 discussion.
closes #13180
Checklist
<link to issue>
"