retry on locked errors when getting lost followers #15187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
force-pushed
the
retry-lost-followers
branch
from
7d8e041 to
efb8099
Compare
CodSpeed Performance ReportMerging #15187 will not alter performanceComparing Summary
|
zzstoatzz
force-pushed
the
retry-lost-followers
branch
from
efb8099 to
958e948
Compare
cicdw
reviewed
Sep 3, 2024
| @@ -513,6 +514,13 @@ async def reactive_evaluation(event: ReceivedEvent, depth: int = 0): | |||
| await session.commit() | |||
|
|
|||
|
|
|||
| # retry on operational errors to account for db flakiness with sqlite | |||
| @retry_async_fn(max_attempts=3, retry_on_exceptions=(sa.exc.OperationalError,)) | |||
There was a problem hiding this comment.
i love how we have an internal utility with a better UX than our retry settings on tasks 😂 🙃
cicdw
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15170
we should probably review access patterns to improve sqlite performance across the board, but this appears to avoid the errors described in the linked issue