Deployment.concurrency_limit cannot be zero. #15228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks API schemas for the recently added
Deployment.concurrency_limit
field to narrow allowed values to exclude the literal value0
as it's confusing how it intersects withconcurrency_limit=None
and disabling a deployment.Important
This is technically a breaking api change and is also inconsistent with Work pool concurrency limits which similarly allow 0.
We want to do this while this feature is still rather new/in-development and to pre-empt confusion with disabling deployments.
Also worth noting that the UI will include client-side validation for this greater-than-0 behavior already
Happy to close this small PR though if we think this additional validation isn't worth it
Checklist
<link to issue>
"mint.json
.