Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test flake and add uv dev dependency #15251

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Fix test flake and add uv dev dependency #15251

merged 3 commits into from
Sep 6, 2024

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Sep 5, 2024

Closes #15077

Additionally:

  • adds uv as a dev dependency
  • enforces pydantic>=2.9.0 in generating openAPI schema to avoid noisy commits

@github-actions github-actions bot added bug Something isn't working upstream dependency An upstream issue caused by a bug in one of our dependencies labels Sep 5, 2024
@@ -53,23 +53,12 @@ def test_read_write(self, store, result):

async def test_read_locked_key(self, store, result):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desertaxle let me know if this isn't maintaining the spirit of this test and i can revisit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's mostly in the spirit. One of the things this test was checking was that reads will block until the lock is released. I think it's still worth it to have a test for that, but removing the flake is more important.

@cicdw cicdw added the development Tech debt, refactors, CI, tests, and other related work. label Sep 5, 2024
Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #15251 will not alter performance

Comparing fix-test-flake (fb3d1c4) with main (8ecdce4)

Summary

✅ 3 untouched benchmarks

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defer to alex on the spirit on the test but uv change looks 👌

@cicdw cicdw merged commit c6b2ffe into main Sep 6, 2024
32 checks passed
@cicdw cicdw deleted the fix-test-flake branch September 6, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development Tech debt, refactors, CI, tests, and other related work. upstream dependency An upstream issue caused by a bug in one of our dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flake test_read_locked_key - _queue.Empty
3 participants