check api compatibility when entering a client context #15252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #15252 will not alter performanceComparing Summary
|
jakekaplan
commented
Sep 5, 2024
src/prefect/context.py
Outdated
| @@ -210,6 +210,7 @@ def __enter__(self): | |||
| self._context_stack += 1 | |||
| if self._context_stack == 1: | |||
| self.client.__enter__() | |||
| self.client.api_compatible() | |||
There was a problem hiding this comment.
This and below seemed like the best place to put this so that it only called once
jakekaplan
commented
Sep 5, 2024
jakekaplan
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
cicdw
requested changes
Sep 5, 2024
cicdw
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When entering a
SyncClientContextorAsyncClientContextfor the first time, check if the client and server are compatible.This PR defines compatibility as both the client and server must be on the same major version. The goal of this pr is specifically to flag incompatibility between
2.xand3.xclients and servers (in both directions). I'm very open to changing this in anyway that makes it more useful and future proof for the direction of the package.