Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add function name to prefect-docker cache key #15262

Merged
merged 3 commits into from
Sep 6, 2024
Merged

add function name to prefect-docker cache key #15262

merged 3 commits into from
Sep 6, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Sep 6, 2024 •
edited
Loading

closes #15258

will backport to 2.x

this issue is that all @cacheable decorated functions were only looking at the parameters passed in, which means that push_docker_image was hitting the cache from build_docker_image if they were called with the same image and tag, for example

@github-actions github-actions bot added bug Something isn't working integrations Related to integrations with other services labels Sep 6, 2024
@zzstoatzz zzstoatzz added the fix A fix for a bug in an existing feature label Sep 6, 2024
@zzstoatzz zzstoatzz self-assigned this Sep 6, 2024
@zzstoatzz zzstoatzz mentioned this pull request Sep 6, 2024
Merged
cicdw
cicdw approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzstoatzz zzstoatzz merged commit f3fbf95 into main Sep 6, 2024
13 checks passed
@zzstoatzz zzstoatzz deleted the docker-step-cache-key branch September 6, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

Assignees

@zzstoatzz zzstoatzz

Labels
bug Something isn't working fix A fix for a bug in an existing feature integrations Related to integrations with other services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefect-docker push_docker_image unwanted cache hit
2 participants
@zzstoatzz @cicdw