Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move expensive filter to AND #15286

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Move expensive filter to AND #15286

merged 1 commit into from
Sep 9, 2024

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Sep 9, 2024

A user identified that this was a problematic expression to include in the OR as it risks returning massive numbers of subflow runs; this PR correctly moves the expression to the AND of the where clause, which will hopefully close #15231

@github-actions github-actions bot added bug Something isn't working great writeup This is a wonderful example of our standards performance Related to an optimization or performance improvement labels Sep 9, 2024
Copy link

codspeed-hq bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #15286 will not alter performance

Comparing cancellation-query (bbad44a) with main (978df16)

Summary

✅ 3 untouched benchmarks

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me!

Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@cicdw cicdw merged commit e181478 into main Sep 9, 2024
33 checks passed
@cicdw cicdw deleted the cancellation-query branch September 9, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working great writeup This is a wonderful example of our standards performance Related to an optimization or performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CancellationCleanup service pegs CPU to 100%
3 participants