Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix S3Bucket.download_object_to_path #15293

Merged
merged 4 commits into from
Sep 10, 2024
Merged

fix S3Bucket.download_object_to_path #15293

merged 4 commits into from
Sep 10, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Sep 9, 2024 •
edited
Loading

closes #12848

I think the issue was just a transcription error, where we had this bucket_path that was only "not-unused" because we were logging it out, but we were passing the unprocessed from_path to the download_file boto method

@github-actions github-actions bot added the upstream dependency An upstream issue caused by a bug in one of our dependencies label Sep 9, 2024
@zzstoatzz zzstoatzz added the integrations Related to integrations with other services label Sep 9, 2024
@zzstoatzz zzstoatzz changed the title fix download_object_to_path fix S3Bucket.download_object_to_path Sep 9, 2024
@github-actions github-actions bot added the docs label Sep 9, 2024
@zzstoatzz zzstoatzz marked this pull request as ready for review September 9, 2024 21:28
@zzstoatzz zzstoatzz self-assigned this Sep 9, 2024
cicdw
cicdw approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh good example of why you can't always rely on linting to catch these things!

@zzstoatzz zzstoatzz merged commit 39a4f52 into main Sep 10, 2024
16 checks passed
@zzstoatzz zzstoatzz deleted the aws-s3-download-to-path branch September 10, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

Assignees

@zzstoatzz zzstoatzz

Labels
docs integrations Related to integrations with other services upstream dependency An upstream issue caused by a bug in one of our dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefect AWS S3Bucket download_object_to_path not accurately calculating from path
2 participants
@zzstoatzz @cicdw