-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for prefect-client
version in prefect-client workflow
#15624
Conversation
CodSpeed Performance ReportMerging #15624 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, works for me
@@ -95,7 +95,7 @@ jobs: | |||
|
|||
- name: Start server | |||
run: | | |||
prefect server start& | |||
PREFECT_HOME=$(pwd) prefect server start& |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aha nice catch
@@ -49,7 +49,7 @@ def get_config() -> VersioneerConfig: | |||
# _version.py | |||
cfg = VersioneerConfig() | |||
cfg.VCS = "git" | |||
cfg.style = "pep440" | |||
cfg.style = "pep440-pre" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
Fixes an issue where the
__version__
attribute is not populating correctly. The root cause is that thesetup.py
that theprefect-client
package uses doe not include acmdclass
. Thatcmdclass
generates the_version.py
file that encodes the current version when we build the library. It was likely left out because we delete files in CI, which leads toversioneer
adding a.dirty
to the generated version.After trying several other approaches, I changed the version style that
versioneer
uses for version generation topep440-pre
, which ignores dirty changes. This isn't ideal since we lose information with this style, but it does fix the issue. We should consider alternative ways of buildingprefect-client
that don't require such changes.I also added a check to ensure that
prefect-client
correctly matches the version ofprefect
from this point on.Closes #15620