[UI v2] Edit variables #16035
Merged
[UI v2] Edit variables #16035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
requested review from
aaazzam,
cicdw and
zzstoatzz
as code owners
desertaxle
force-pushed
the
ui-v2-variables-edit
branch
from
a7b819b to
f6f5d13
Compare
desertaxle
added
development
aaazzam
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to edit existing variables. It repurposes the existing variable dialog to handle edits. Here's what it looks like:
Screen.Recording.2024-11-16.at.2.07.02.PM.mov
This PR also starts to experiment with colocating hooks for common operations. Since this is the last major piece of functionality for variables, I'll review and refactor some parts to simplify the organization and increase reusability. Colocating hooks and query keys will be a part of that refactor.
Related to #15512