Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BaseFlowRunEngine and AsyncFlowRunEngine shell #16091

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

desertaxle
Copy link
Member

This PR creates a BaseFlowRunEngine similar to BaseTaskRunEngine to enable fully asynchronous flow runs. The PR also copies the existing FlowRunEngine to AsyncFlowRunEngine, which will eventually be the async implementation. Both classes are identical right now, and this PR gets the larger structure in place so the diffs in subsequent PRs will be easier to read.

Related to #15415

Also create copy of `FlowRunEngine` to support async changes
@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Nov 22, 2024
Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #16091 will not alter performance

Comparing async-flow-run-engine (d9e3a05) with main (062d147)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle changed the title Create BaseFlowRunEngine Create BaseFlowRunEngine and AsyncFlowRunEngine shell Nov 22, 2024
@desertaxle desertaxle marked this pull request as ready for review November 22, 2024 16:23
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@desertaxle desertaxle merged commit ede23b1 into main Nov 22, 2024
40 checks passed
@desertaxle desertaxle deleted the async-flow-run-engine branch November 22, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants