Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install otel extras in docker image and remove experimental flag setting #16412

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bunchesofdonald
Copy link
Contributor

Now that we have the client-side traces in a good place this removes the experimental flag and makes telemetry enable based on whether or not it's talking to cloud and the otel extras are installed. It also installs the otel extras in the docker image by default.

Closes CLOUD-842

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #16412 will not alter performance

Comparing CLOUD-842 (5588d35) with main (cf9b00a)

Summary

✅ 3 untouched benchmarks

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit on the setting name, but otherwise this looks good to me!

src/prefect/settings/models/cloud.py Outdated Show resolved Hide resolved
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants