-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install otel
extras in docker image and remove experimental flag setting
#16412
Open
bunchesofdonald
wants to merge
7
commits into
main
Choose a base branch
from
CLOUD-842
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bunchesofdonald
requested review from
discdiver,
cicdw,
desertaxle and
zzstoatzz
as code owners
December 16, 2024 21:21
CodSpeed Performance ReportMerging #16412 will not alter performanceComparing Summary
|
bunchesofdonald
force-pushed
the
CLOUD-842
branch
from
December 17, 2024 15:35
4a3d964
to
b30de6d
Compare
bunchesofdonald
force-pushed
the
CLOUD-842
branch
from
December 17, 2024 15:49
b30de6d
to
d3d1143
Compare
desertaxle
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit on the setting name, but otherwise this looks good to me!
desertaxle
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the client-side traces in a good place this removes the experimental flag and makes telemetry enable based on whether or not it's talking to cloud and the otel extras are installed. It also installs the otel extras in the docker image by default.
Closes CLOUD-842