Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLA: First Pass at SLA Schemas and flow.deploy Update #16455

Conversation

dylanbhughes
Copy link
Contributor

@dylanbhughes dylanbhughes commented Dec 19, 2024

This PR introduces SLAs to deployments as an experimental feature.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #16455 will not alter performance

Comparing dylan/cloud-870-add-the-sla-schema-objects-to-oss (65cf7dd) with main (e3a6fe4)

Summary

✅ 3 untouched benchmarks

@dylanbhughes dylanbhughes changed the title first pass at Sla schema SLA: First Pass at SLA Schemas and flow.deploy Update Dec 19, 2024
@aaazzam
Copy link
Collaborator

aaazzam commented Dec 20, 2024

Trying to figure out if notifications are too tightly coupled to the SLA itself. What if we pulled out the notification stuff entirely? The SLA itself could just focus on time limits and violations, then we handle notifications separately. Makes it easier to add different actions later too. lmk what you think @dylanbhughes

@dylanbhughes dylanbhughes marked this pull request as ready for review December 26, 2024 16:31
@dylanbhughes dylanbhughes requested a review from aaazzam December 26, 2024 16:33
Copy link
Contributor

@sam-phinizy sam-phinizy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No blockers on my end, some questions about how we want to handle some SLAs being made and some not. Also about how we can future proof against having SLAs belonging to things that aren't deployments.

src/prefect/_experimental/sla.py Show resolved Hide resolved
src/prefect/client/orchestration.py Show resolved Hide resolved
@dylanbhughes dylanbhughes merged commit 54e3d07 into dylanbhughes/deployment-sla Dec 31, 2024
34 checks passed
@dylanbhughes dylanbhughes deleted the dylan/cloud-870-add-the-sla-schema-objects-to-oss branch December 31, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants