-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLA: First Pass at SLA Schemas and flow.deploy Update #16455
SLA: First Pass at SLA Schemas and flow.deploy Update #16455
Conversation
CodSpeed Performance ReportMerging #16455 will not alter performanceComparing Summary
|
Trying to figure out if notifications are too tightly coupled to the SLA itself. What if we pulled out the notification stuff entirely? The SLA itself could just focus on time limits and violations, then we handle notifications separately. Makes it easier to add different actions later too. lmk what you think @dylanbhughes |
…different client method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No blockers on my end, some questions about how we want to handle some SLAs being made and some not. Also about how we can future proof against having SLAs belonging to things that aren't deployments.
…efect into dylan/cloud-870-add-the-sla-schema-objects-to-oss
This PR introduces SLAs to deployments as an experimental feature.
Checklist
<link to issue>
"mint.json
.