Fix TypeError in SnowflakeConnector.fetch_all
#16511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
added
integrations
zzstoatzz
changed the title
fetch_all to execute query before calling fetchall
zzstoatzz
changed the title
fetch_all to execute query before calling fetchallTypeError in SnowflakeConnector.fetch_all
desertaxle
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16110
The
fetch_allmethod was failing withTypeError: 'NoneType' object is not an iteratorbecause it was trying to fetch results before executing the query. This fix ensures the query is executed on the cursor before attempting to fetch results.