Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing in prefect.server.events #16692

Merged
merged 4 commits into from
Jan 11, 2025
Merged

Improve typing in prefect.server.events #16692

merged 4 commits into from
Jan 11, 2025

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jan 11, 2025 •
edited
Loading

This PR improves the typing in prefect.server.events (more work still needed) and pushes us just above 90% type completeness! 🎉

@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Jan 11, 2025
@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 11, 2025
@desertaxle desertaxle removed the ui-replatform Related to the React UI rewrite label Jan 11, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 11, 2025

CodSpeed Performance Report

Merging #16692 will not alter performance

Comparing typing-server-events (2754faa) with main (d069600)

Summary

✅ 2 untouched benchmarks

@desertaxle desertaxle marked this pull request as ready for review January 11, 2025 21:51
cicdw
cicdw approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiiice

@desertaxle desertaxle merged commit eb44a8d into main Jan 11, 2025
49 checks passed
@desertaxle desertaxle deleted the typing-server-events branch January 11, 2025 23:49
zzstoatzz pushed a commit that referenced this pull request Jan 14, 2025
@desertaxle @zzstoatzz
Improve typing in prefect.server.events (#16692)
0d8ba9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desertaxle @cicdw