Add PrefectDbtSettings to prefect-dbt
#16834
Conversation
CodSpeed Performance ReportMerging #16834 will not alter performanceComparing Summary
|
kevingrismore
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
| @field_validator("target_configs", mode="before") | ||
| @classmethod | ||
| def handle_target_configs(cls, v: Any) -> Any: | ||
| """Handle target configs field aliasing during validation""" | ||
| if isinstance(v, dict): | ||
| if "schema_" in v: | ||
| v["schema"] = v.pop("schema_") | ||
| # Handle nested blocks | ||
| for value in v.values(): | ||
| if isinstance(value, dict) and "schema_" in value: | ||
| value["schema"] = value.pop("schema_") | ||
| return v |
There was a problem hiding this comment.
This validator feels like it should be on BaseTargetConfigs instead. I think you wouldn't have to worry about nested blocks in that case.
There was a problem hiding this comment.
@desertaxle i mentioned this here, maybe it should be a before model_validator instead of field_validator? bc the alias schema_ presents an issue with the field_validator I think
There was a problem hiding this comment.
For posterity, @zzstoatzz and I looked at this quite thoroughly, and it seems like we are inconsistent in our use of aliases when dumping Blocks. We agreed that the current validator approach is a good short term option and we'll work on adding additional validation aliases to schema_ fields to ensure we handle the inconsistency in Block dumping.
kevingrismore
force-pushed
the
add-dbt-settings
branch
from
2fae812 to
58c426e
Compare
This introduces
PrefectDbtSettings, which automatically detects a common set ofDBT_-prefixed env vars upon instantiation. Intended for use withPrefectDbtRunner.Checklist
<link to issue>"mint.json.