Fix/init scripts #44
Open
Fix/init scripts #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readOnly configmap workaround
merge master
Chrislevi
commented
Aug 18, 2018
| @@ -11,16 +12,16 @@ RELEASE=$1 | |||
| NAMESPACE=$2 | |||
| CHART_NAME="vault" | |||
| COMPONENT="${RELEASE}-vault" | |||
| ADD_SECRET=${3-"false"} | |||
There was a problem hiding this comment.
suggested default change, breaks with previous deploys although it is not necessary towards the label refactor
Chrislevi
commented
Aug 18, 2018
|
|
||
| SECRET_NAME="$RELEASE-vault-keys" | ||
|
|
||
| LABELS=$(kubectl get secret -l release=$RELEASE -n $NAMESPACE --show-labels | sed -n 2p | awk '{print $5}' | sed 's/\,/ /g') | ||
| FIRST_VAULT_POD=$(kubectl get po -l component=$COMPONENT,release=$RELEASE -n $NAMESPACE | awk '{if(NR==2)print $1}') | ||
| INIT_MESSAGE=$(kubectl exec -n $NAMESPACE -c $RELEASE $FIRST_VAULT_POD -- sh -c "vault operator init --tls-skip-verify" 2>&1) |
There was a problem hiding this comment.
$RELEASE is not the container's name inside the pod. changed it to an exsiting var $COMPONENT which holds the correct name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few minor fixes to the init scripts.
vault-init.sh:15 - suggested default change, breaks with previous deploys although it is not necessary towards the label refactor
vault-unseal.sh:26 - $RELEASE is not the container's name inside the pod. changed it to an exsiting var $COMPONENT.