Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

[*] blockcategories: assing current starting category to template #12

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[*] blockcategories: assing current starting category to template #12

wants to merge 1 commit into from

Conversation

natrim
Copy link

@natrim natrim commented Mar 31, 2015

it's useful if i want to display parent information in template and not only current category

@maximebiloe
Copy link
Contributor

Hello,

Thank you for your PR.
The variable is not used into the tpl files. Can you explain more why you're assigning this variable, please ?

Best regards

@natrim
Copy link
Author

natrim commented May 13, 2015

Somebody, might want to use it in template.
We do, and to prevent removing after module update i am adding here. (+ as i said some tohe one might want to use it too)

@maximebiloe
Copy link
Contributor

Hello,

Ok, I understand. But if you want to make a PR, you need to add/correct a complete feature.
Please, update the TPL files too so we will have a complete visibility of it.

Thanks in advance.

Regards

@natrim
Copy link
Author

natrim commented May 14, 2015

The point is that is is optional,
sometimes you want to change in template:

{if isset($currentCategory)}{$currentCategory->name|escape}{else}{l s='Categories' mod='blockcategories'}{/if}

to

{$startingCategory->name|escape}

EDIT: I added comment to template though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants