Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: The new password policy is not present in the reset password #140

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

Codencode
Copy link
Contributor

Questions Answers
Description? if you try to do the password reset steps, you will get the reset page where to set a new password two times
from this page is not present the new password verification, in fact it is possible to set weak password
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #35410
Sponsor company Codencode
How to test? 1. go at login
2. push on the link "I don't remember the password"
3. set an email to get the reset link
4. push on the reset link
5 set a new password, but weak like "casetta"
6. Password verification will not appear

@Codencode Codencode changed the title Update password-new.tpl Fix: The new password policy is not present in the reset password Feb 19, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Feb 26, 2024
@kpodemski
Copy link
Contributor

@AureRita since you tested the original PR, I think we can merge it?

@kpodemski kpodemski added this to the 2.1.3 milestone Feb 26, 2024
@AureRita AureRita self-assigned this Feb 26, 2024
@AureRita
Copy link

Hi @kpodemski

Yes, indeed, you can merge this PR because it's tested with PrestaShop/PrestaShop#35418

Thank you

@AureRita AureRita added QA ✔️ Status: QA-Approved and removed Waiting for QA Status: Waiting for QA feedback labels Feb 26, 2024
@Hlavtox Hlavtox merged commit efb5fa7 into PrestaShop:2.1.x Feb 26, 2024
4 checks passed
matthieu-rolland added a commit that referenced this pull request Apr 10, 2024
…olicy

Backport PR #140 (Fix: The new password policy is not present in the reset password)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA ✔️ Status: QA-Approved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants