Replace smarty condition "else if" by "elseif" #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Klemart3D
commented
Mar 1, 2024
•
Klemart3D
commented
| Questions | Answers |
|---|---|
| Description? | Replace smarty condition "else if" by "elseif" following official doc |
| Type? | refactor |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Partially #604 (must be also applied into Humminbird theme & modules) |
| Sponsor company | Your company or customer's name goes here (if applicable). |
| How to test? | Search for "{else if" in whole .tpl files, there must be "0 results" |
|
Pull request also made for Hummingbird theme : PrestaShop/hummingbird#605 |
SharakPL
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
Hi @Klemart3D and thanks for your PRs.
It's a really old doc you referenced there 😉 But in this part it's still valid in Smarty v.4 currently used in Prestashop so good job. Thank you 👍
florine2623
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Hello @Klemart3D ,
LGTM ✅
classic theme on product page and contact page are well displayed.
Thanks!
florine2623
added
QA ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.