Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial for creating automatically xlf translation file - Update new-system.md #1720

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

vcopleutre
Copy link
Contributor

For new module developpers, one of our questions is "how to create the translation file".

This part add the best practice (according to my own judgement) do to it.

The syntax may not be efficient, feel free to reword it or add internal anchors to the text.

Questions Answers
Branch? 8.x
Description? Answering the question for developpers : "how to create automatically the xlf translation file in my module"
Fixed ticket? none

For new module developpers, one of our questions is "how to create the translation file".

This part add the best practice (according to my own judgement) do to it.

The syntax may not be efficient, feel free to reword it or add internal anchors to the text.
@github-actions github-actions bot added the 8.x label Aug 30, 2023
Copy link
Contributor

@thomasnares thomasnares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vcopleutre, i added a few suggestions with internal linking 👍

modules/creation/module-translation/new-system.md Outdated Show resolved Hide resolved
modules/creation/module-translation/new-system.md Outdated Show resolved Hide resolved
modules/creation/module-translation/new-system.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! a few comments and it's all good :)

modules/creation/module-translation/new-system.md Outdated Show resolved Hide resolved
modules/creation/module-translation/new-system.md Outdated Show resolved Hide resolved
modules/creation/module-translation/new-system.md Outdated Show resolved Hide resolved
modules/creation/module-translation/new-system.md Outdated Show resolved Hide resolved
modules/creation/module-translation/new-system.md Outdated Show resolved Hide resolved
Co-authored-by: Krystian Podemski <[email protected]>
@kpodemski
Copy link
Contributor

thanks for contributing @vcopleutre !

@kpodemski kpodemski merged commit cae486d into PrestaShop:8.x Aug 31, 2023
2 checks passed
@vcopleutre
Copy link
Contributor Author

Thank you for the updates!

@vcopleutre vcopleutre deleted the patch-1 branch August 31, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants