Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nginx.md #1729

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Update nginx.md #1729

merged 2 commits into from
Dec 28, 2023

Conversation

PiotrBracha
Copy link
Contributor

Few improvements inside the Nginx's configuration.

Questions Answers
Branch? I use Prestashop 1.7.8.8 with Nginx 1.22.1
Description? My PR includes adding more security headers, some improvements in access/error log files and regarding the Nginx docs - the proper use of try_files instead of "if" condition
Fixed ticket? it does not fix any issue

@PiotrBracha
Update nginx.md
c25c357 
Few improvements inside the Nginx's configuration.
@github-actions github-actions bot added the 8.x label Sep 14, 2023
matks
matks reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a newbie in NGINX 😆

Would love a review from people better skilled - @jokesterfr ? @JMorinPS ?

@matks
Copy link
Contributor

matks commented Sep 20, 2023

One more try @jokesterfr @JMorinPS @djodjo3 😄

@kpodemski
Copy link
Contributor

cc @jokesterfr

kpodemski
kpodemski approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, I did the research, and all the changes are valid. Thanks @PiotrBracha

@kpodemski kpodemski merged commit bebba3f into PrestaShop:8.x Dec 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks left review comments

@kpodemski kpodemski kpodemski approved these changes

@tleon tleon tleon approved these changes

Assignees
No one assigned
Labels
8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PiotrBracha @matks @kpodemski @tleon