Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Flashlight to devdocs #1761

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Introduce Flashlight to devdocs #1761

merged 3 commits into from
Dec 19, 2023

Conversation

thomasnares
Copy link
Contributor

Questions Answers
Branch? 8.x
Description? Introduce Flashlight to devdocs

@github-actions github-actions bot added the 8.x label Dec 4, 2023
@thomasnares
Copy link
Contributor Author

@jokesterfr you may have remarks or important notes to add to this page, or let me know and i add them 👍

matthieu-rolland
matthieu-rolland approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍 let's wait for @jokesterfr 's point of view

kpodemski
kpodemski reviewed Dec 5, 2023
View reviewed changes
basics/installation/advanced/prestashop-flashlight.md Outdated Show resolved Hide resolved
basics/installation/advanced/prestashop-flashlight.md Outdated Show resolved Hide resolved
basics/installation/advanced/prestashop-flashlight.md Outdated Show resolved Hide resolved
basics/installation/environments/docker.md Outdated Show resolved Hide resolved
basics/installation/environments/docker.md Outdated Show resolved Hide resolved
basics/installation/environments/docker.md Outdated Show resolved Hide resolved
@thomasnares @kpodemski
Apply suggestions from code review
b92da5a 
Co-authored-by: Krystian Podemski <[email protected]>
@kpodemski
Copy link
Contributor

Hi @jokesterfr

Can you please verify if everything is alright?

kpodemski
kpodemski requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jokesterfr feedback to be applied

@thomasnares
Copy link
Contributor Author

Added the example for module dev here: PrestaShop/prestashop-flashlight#49

@kpodemski kpodemski merged commit 5c5865d into PrestaShop:8.x Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokesterfr jokesterfr jokesterfr left review comments

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@kpodemski kpodemski kpodemski approved these changes

Assignees
No one assigned
Labels
8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasnares @kpodemski @jokesterfr @matthieu-rolland