Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New carriers pages docs #1858

Merged
merged 1 commit into from
Sep 4, 2024
Merged

New carriers pages docs #1858

merged 1 commit into from
Sep 4, 2024

Conversation

boherm
Copy link
Member

@boherm boherm commented Sep 3, 2024 •
edited
Loading

Questions Answers
Branch? 9.x
Description? This PR aim to add some tech docs about new Carriers pages in BackOffice.
Fixed ticket? Fixes PrestaShop/PrestaShop#10586

@boherm boherm requested a review from tleon September 3, 2024 16:00
@github-actions github-actions bot added the 9.x label Sep 3, 2024
matks
matks reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ;) please find 1 typo and 2 improvements

development/page-reference/back-office/carrier/add-new-carrier/_index.md Outdated Show resolved Hide resolved
development/page-reference/back-office/carrier/add-new-carrier/_index.md Outdated Show resolved Hide resolved
development/page-reference/back-office/carrier/add-new-carrier/_index.md Outdated Show resolved Hide resolved
@boherm boherm marked this pull request as draft September 4, 2024 07:35
@boherm boherm changed the title New carriers pages docs [WIP] New carriers pages docs Sep 4, 2024
@boherm boherm requested a review from matks September 4, 2024 07:54
matks
matks approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

I see it's still a draft. i think we can nevertheless merge it and update it later, wdyt?

@boherm boherm marked this pull request as ready for review September 4, 2024 15:14
@boherm boherm changed the title [WIP] New carriers pages docs New carriers pages docs Sep 4, 2024
@boherm boherm merged commit 636910b into PrestaShop:9.x Sep 4, 2024
2 checks passed
@boherm boherm deleted the carriers-docs branch September 4, 2024 15:14
@boherm
Copy link
Member Author

boherm commented Sep 4, 2024

Done! Thanks guys ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@tleon tleon tleon approved these changes

Assignees
No one assigned
Labels
9.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boherm @matks @tleon