Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use right classes on form for demosymfonyform #113

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Use right classes on form for demosymfonyform #113

merged 1 commit into from
Oct 19, 2022

Conversation

mflasquin
Copy link
Contributor

@mflasquin mflasquin commented Oct 13, 2022 •
edited by matks
Loading

Questions Answers
Description? The form was not well displayed with prestashop 8 because of uses wrong html classes on it
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #108
How to test? Install module demosymfonyform > Configure the module > Check form display
Possible impacts?

@matks matks changed the title Use right classes on form Use right classes on form for demosymfonyform Oct 19, 2022
@matks
Copy link
Contributor

matks commented Oct 19, 2022

tested on localhost thank you @mflasquin

@matks matks merged commit bb8ec69 into PrestaShop:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiix atomiix atomiix approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make example modules works with Prestashop 8.0
3 participants
@mflasquin @matks @atomiix