Update category-header.tpl

[rodriciru]

close #476

[sudo-do]

Since I don't see a reason to get invalid index in line 14.

[rodriciru]

Not necessary IMO

[rodriciru]

I dont know how to reject this changes, so i hope i do it ok

[sudo-do]

yeah, the change is not nessesary as far as i know prestashop environment

[florine2623]

Hello @rodriciru ,

I tried to install your PR, but I have an error, the theme can't be applied to my FO :

cd themes            
rm -rf hummingbird
git clone https://github.com/PrestaShop/hummingbird.git hummingbird
cd hummingbird
git prc origin 477 dev
cd _dev && npm i && npm run build

I also tested to install your PR on the theme hummingbird v0.1.5.
No PR, hummingbird il well installed :

Once I install your PR with, my FO is broken :

Is there something I'm doing incorrectly ?

Also, could you add a "How to test" with screenshots as well ?

Thanks!

[Hlavtox]

@rodriciru Can you show what error you are getting? I deleted the images from the category but I get no error 🤔

[rodriciru]

Hello @rodriciru ,

I tried to install your PR, but I have an error, the theme can't be applied to my FO :

cd themes            
rm -rf hummingbird
git clone https://github.com/PrestaShop/hummingbird.git hummingbird
cd hummingbird
git prc origin 477 dev
cd _dev && npm i && npm run build

I also tested to install your PR on the theme hummingbird v0.1.5. No PR, hummingbird il well installed :

Once I install your PR with, my FO is broken :

Is there something I'm doing incorrectly ?

Also, could you add a "How to test" with screenshots as well ?

Thanks!

Highly improbable that that was my fault. I think you also delete the CSS when do the rm command. SO you have no CSS so the website look like this. You have to compile the asset's folder, but that has nothing to do with this PR

[rodriciru]

@rodriciru Can you show what error you are getting? I deleted the images from the category but I get no error 🤔

More than an error is a PHP warning in server logs. I have fixed that at my store, so I get no more warnings
You are looking for a value that is null, and this throw a warning

[Hlavtox]

@rodriciru It doesn't throw me a warning even if $category.image is null 🤔, the condition catches it without a notice/error. Weird. I checked both PHP and Symfony error logs and nothing in both.

@kpodemski Do you get an error if you have a category without an image and do this? I don't for some reason.

{if !empty($category.image.large.url)}
    {$category.image.large.url}
{/if}

[rodriciru]

I get a php warning at smarty compile (i suppose if i disable cache i will get something similar)
The warning looks like this, but is not exactly this:
[03-Apr-2023 17:23:21 Europe/Madrid] PHP Warning: Trying to access array offset on value of type null in /usr/home/XXXX/web/var/cache/prod/smarty/compile/XXXXXlayouts_layout_left_column_tpl/00/78/cc/0078ccc9839dcacadc15c0f4aa16f402af5079aa_2.file.category.tpl.php on line 57

[kpodemski]

@rodriciru that's odd, empty for this key should be safe 🤔 have you checked this file 078ccc9839dcacadc15c0f4aa16f402af5079aa_2.file.category.tpl.php on line 57 to see if it is really about this line?

[rodriciru]

@rodriciru that's odd, empty for this key should be safe 🤔 have you checked this file 078ccc9839dcacadc15c0f4aa16f402af5079aa_2.file.category.tpl.php on line 57 to see if it is really about this line?

Yep, it's weird as hell, but I have some answers.
Looking at compiled PHP, I see that some empty functions translate to simple if's and others don't.
Concretely, this image empty translates to if and the empty 2 lines above translate to an empty instead of an if:
PLEASE KEEP IN MIND It's NOT EXACTLY THIS FILE, BUT IT'S ALMOST THE SAME
Original smarty tpl:

{if !empty($category.image)}
                    <div class="category-cover">
                        <img src="{$category.image.large.url}" alt="{if !empty($category.image.legend)}{$category.image.legend}{else}{$category.name}{/if}" loading="lazy" width="141" height="180">
                    </div>
                {/if}

Compiled result:

            <?php if ($_smarty_tpl->tpl_vars['category']->value['image']) { ?>
                <div class="category-cover">
                  <img src="<?php echo htmlspecialchars((string) $_smarty_tpl->tpl_vars['category']->value['image']['large']['url'], ENT_QUOTES, 'UTF-8'); ?>
" alt="<?php if (!empty($_smarty_tpl->tpl_vars['category']->value['image']['legend'])) {
                  echo htmlspecialchars((string) $_smarty_tpl->tpl_vars['category']->value['image']['legend'], ENT_QUOTES, 'UTF-8');
                } else {
                  echo htmlspecialchars((string) $_smarty_tpl->tpl_vars['category']->value['name'], ENT_QUOTES, 'UTF-8');
                } ?>">
                </div>
            <?php } ?>

Effectively, empty not raises any warnings, but if does, so this is why we get the warning.
Still, I think this is an easy and no harmful at all fix, even if the blame of the issue is smarty

[leemyongpakvn]

@florine2623 FYI, hummingbird is different from classic-theme. There is no _dev directory in hummingbird, you need to create a .env file inside its webpack directory, and run npm run build from hummingbird directory following this cookbook https://github.com/PrestaShop/hummingbird#how-to-build-assets ;)

[leemyongpakvn]

@florine2623 Please check my message above when you have time. By the way, I can't understand the logic of this PR. ;)

[florine2623]

Hello @rodriciru ,

It seems like no one can reproduce your issue, neither @Hlavtox , @kpodemski nor @leemyongpakvn .

Could you explain further so it can be reproduced and tested ?

[rodriciru]

Hard to explain it more.
I think I explain it very well, smarty produces different structures for empty, one throws a WARNING, the other don't.
I still think the PR won't break anything, but if you don't feel right with this, close the issue, as I'm the only who get this.
Thanks!

[leemyongpakvn]

As usual, QA will close the issue if they can not reproduce it 👌

[Hlavtox]

@rodriciru I will try to reproduce once again, if you really say it happens. There is no reason for smarty to convert empty to if. If it does so, it's stupid. 🤔

On what core version you are getting this behavior?

[Prestaworks]

{if !empty($category.image.large.url)} is also present in classic theme, I tried deleting the category images, "image" => null shows on the category dump, tested on PS 8.1.2 and php 7.2, 7.4 and 8.1 still nothing in the php logs or Prestashop log files.

so if this is caused by "image" not existing it's maybe an older PS version?
To make the check safe it should maybe be something like
{if !empty($category.image) && !empty($category.image.large)}

But I can't recreate the error on PS 8.1.2.

[rodriciru]

I don't remember exactly the version, but I try to keep the latest version of ps on my stores. So by the time the issue is created, the most recent version at that time. Anyway,seeing I'm the only,and can't reproduce by any of yours, let's close and will open a new one if happens again El vie, 8 dic 2023 13:21, Daniel ***@***.***> escribió:

…

{if !empty($category.image.large.url)} is also present in classic theme, I tried deleting the category images, "image" => null shows on the category dump, tested on PS 8.1.2 and php 7.2, 7.4 and 8.1 still nothing in the php logs or Prestashop log files. so if this is caused by "image" not existing it's maybe an older PS version? To make the check safe it should maybe be something like {if !empty($category.image) && !empty($category.image.large)} But I can't recreate the error on PS 8.1.2. — Reply to this email directly, view it on GitHub <#477 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACR6MY62QUHA77W2K7T6RCDYIMA33AVCNFSM6AAAAAAWJLLUUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBXGA3TSNRWGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kpodemski]

@Hlavtox @Prestaworks maybe it was a bug in some Smarty version because I noticed that problem as well, I've had {if !empty($array.key)} it started flooding logs with a warnings/notice.

[Prestaworks]

@Hlavtox @Prestaworks maybe it was a bug in some Smarty version because I noticed that problem as well, I've had {if !empty($array.key)} it started flooding logs with a warnings/notice.

Do you remember what version of PS it was?

[kpodemski]

@Prestaworks 1.7.6 something

[florine2623]

I suggest closing this issue as it cannot be reproduced #476 (comment)