-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit payment option to work with ps_checkout #533
Edit payment option to work with ps_checkout #533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ps_checkout is not a native module, this is why the fix shouldn't be there
if changes in .tpl are valid for other payment methods, it's ok, but CSS rules shouldn't be part of Hummingbird
you can easily add it to your version of the theme, or contribute to ps_checkout to display correctly if the theme is Hummingbird
@@ -0,0 +1,10 @@ | |||
.payment__option { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be inside core of Hummingbird but rather inside your theme or ps_checkout module :)
Hello @kpodemski ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tblivet
I tested your PR, the checkout options are well displayed, LGTM ✔️
QA ✔️
Thanks!
Thank you @tblivet ! |
Not easy to test because the shop must have ps_checkout configure, but this should render the payment option like in the screen below : top -> before & bottom -> after ![image](https://github.com/PrestaShop/hummingbird/assets/110676325/519e3161-c91a-465c-9f9b-9e6a7bbeefe4)