Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The price is displayed twice as if there was a discount #538

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix: The price is displayed twice as if there was a discount #538

merged 1 commit into from
Aug 10, 2023

Conversation

tblivet
Copy link
Contributor

@tblivet tblivet commented Aug 8, 2023

Questions Answers
Description? Correct the issue 535
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixe #535
Sponsor company @PrestaShopCorp
How to test? You can refer to the issue

@mflasquin mflasquin changed the title fix: issue 535 fix: The price is displayed twice as if there was a discount Aug 10, 2023
aniszr
aniszr approved these changes Aug 10, 2023
View reviewed changes
Copy link

@aniszr aniszr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet

I tested your PR, the mentioned problem related to double display of prices in FO is solved, LGTM ✔️

See attached screenshot:
Cart

QA ✔️

Hlavtox
Hlavtox requested changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@Hlavtox Hlavtox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aniszr Hi, does it keep the crossed out price? I don't see it on the screenshot. If testing an issue that concerns discounts, you must test a product with a discount. :-)

It should be there, see figma prototype - https://www.figma.com/file/LfVl5leeSKcVUhSaYwhbtM/New-Theme?type=design&node-id=383-12713&mode=design

aniszr
aniszr approved these changes Aug 10, 2023
View reviewed changes
Copy link

@aniszr aniszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed I checked with a product with discount, see the attached screenshot below:

image

Thanks

@aniszr aniszr self-assigned this Aug 10, 2023
@aniszr aniszr requested a review from Hlavtox August 10, 2023 15:39
Hlavtox
Hlavtox approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aniszr :-) Merging

@Hlavtox Hlavtox merged commit 158dbe5 into PrestaShop:develop Aug 10, 2023
6 checks passed
@SharakPL SharakPL mentioned this pull request Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniszr aniszr aniszr approved these changes

@boherm boherm boherm approved these changes

@mflasquin mflasquin mflasquin approved these changes

@Hlavtox Hlavtox Hlavtox approved these changes

Assignees

@aniszr aniszr

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tblivet @Hlavtox @mflasquin @boherm @aniszr @ps-jarvis