Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing add to wishlist button and modals backdrop #584

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

SharakPL
Copy link
Contributor

@SharakPL SharakPL commented Jan 31, 2024

Questions Answers
Description? #568 prevented Add to wishlist button from loading on product list and caused error thrown in the console. thumbnail-container needs to be back in its original place.
It temporary breaks the product rating, but this needs to be fixed in the productcomments module, where wrong selector is being used in js (fix: PrestaShop/productcomments#198)
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company -
How to test? -

Before

obraz

After

obraz

Hlavtox
Hlavtox previously approved these changes Jan 31, 2024
@SharakPL
Copy link
Contributor Author

SharakPL commented Feb 1, 2024

Further changes will be needed inside the productcomments module to avoid this empty space when no rating is available. It's meant for absolutely positioned Classic verstion and it only changes visibility.

IMO it's not the best place for it in Hummingbird. Products without rating will have either big empty space or different position of price, quantity and button and there will be layout shifts all over the page. Maybe we should keep it on the product cover like in Classic, but rather as a single star with score in it eg. 4.5/5, instead of 5 stars.

boherm
boherm previously approved these changes Feb 1, 2024
@SharakPL SharakPL marked this pull request as draft February 1, 2024 19:00
@SharakPL SharakPL dismissed stale reviews from boherm and Hlavtox via d602e92 February 1, 2024 19:31
@SharakPL SharakPL marked this pull request as ready for review February 1, 2024 20:55
@SharakPL
Copy link
Contributor Author

SharakPL commented Feb 1, 2024

Removed whitespaces and literals, fixed modal backdrop class - should be show (BS 5) instead of in (BS 3) to see actual backdrop:

Before

obraz

After

obraz

@SharakPL SharakPL changed the title Fix missing add to wishlist button Fix missing add to wishlist button and modals backdrop Feb 2, 2024
@SharakPL SharakPL requested a review from a team February 2, 2024 12:44
@AureRita AureRita self-assigned this Feb 6, 2024
Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SharakPL

Thank you for your PR, I tested it and it seems to works as you can see :

recording.92.webm

Tested on develop and 8.1.x

Because the PR seems to works perfectly, it's QA ✔️

Thank you

@SharakPL
Copy link
Contributor Author

SharakPL commented Feb 6, 2024

Thanks @AureRita

@SharakPL SharakPL merged commit 5d33762 into PrestaShop:develop Feb 6, 2024
6 checks passed
@SharakPL SharakPL deleted the fix-blockwishlist branch February 19, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants