-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing add to wishlist button and modals backdrop #584
Conversation
Further changes will be needed inside the productcomments module to avoid this empty space when no rating is available. It's meant for absolutely positioned Classic verstion and it only changes IMO it's not the best place for it in Hummingbird. Products without rating will have either big empty space or different position of price, quantity and button and there will be layout shifts all over the page. Maybe we should keep it on the product cover like in Classic, but rather as a single star with score in it eg. 4.5/5, instead of 5 stars. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SharakPL
Thank you for your PR, I tested it and it seems to works as you can see :
recording.92.webm
Tested on develop and 8.1.x
Because the PR seems to works perfectly, it's QA ✔️
Thank you
Thanks @AureRita |
thumbnail-container
needs to be back in its original place.It temporary breaks the product rating, but this needs to be fixed in the productcomments module, where wrong selector is being used in js (fix: PrestaShop/productcomments#198)
Before
After