Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Card: add border #585

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

yannicka
Copy link
Contributor

@yannicka yannicka commented Feb 2, 2024

Questions Answers
Description? Add border on address card (on My Account) and have the same border on checkout address card.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #527
Sponsor company N/A
How to test? Go to "Addresses" and "Checkout"

Before:
Screenshot_20240202_222705
Screenshot_20240202_223706

After:
Screenshot_20240202_222724
Screenshot_20240202_223751

@yannicka yannicka changed the title Address border Address Card: add border Feb 2, 2024
@AureRita AureRita self-assigned this Feb 6, 2024
Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yannicka

Thank you for your PR, I tested it and it seems to works as you can see :

recording.94.webm

Tested on Develop and 8.1.x

I also tested the "avoid bounce on select" and it works

Because the PR seems to works as expected, It's QA ✔️

Thank you

@AureRita AureRita removed their assignment Feb 6, 2024
@boherm boherm merged commit 5c2490c into PrestaShop:develop Feb 7, 2024
6 checks passed
@boherm
Copy link
Member

boherm commented Feb 7, 2024

Thanks @yannicka!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Harmonise the UI of address card
5 participants