Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue-494 #640

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Fix: issue-494 #640

merged 3 commits into from
Jun 26, 2024

Conversation

tblivet
Copy link
Contributor

@tblivet tblivet commented Jun 13, 2024

Questions Answers
Description? Fix #494 : Several style improvements have been made on productcomments.
Type? improvement
BC breaks? no
Deprecations?
Fixed ticket? Fix #494
Sponsor company @PrestaShopCorp
How to test? I think the entire productcomments module needs to be tested.

Before:
comments_before

After:
comments_after

nicosomb
nicosomb previously approved these changes Jun 14, 2024
boherm
boherm previously approved these changes Jun 14, 2024
@florine2623 florine2623 self-assigned this Jun 14, 2024
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet ,

Thanks for the PR ! 🎉

Tested all elements in Configuration block.
Tested Reporting reviews
CRUD Review criterias
Pagination looks good
Rating star color is correct

BUG 1

The button Read user reviews has an anchor a little to low. I can't see the name of the user who posted a comment.

Screen.Recording.2024-06-14.at.16.18.51.mov

BUG 2

Same issue with write your review button. It scrolls down but I don't see the button to write my review.
I actually expect it to open the modal so I can Write my review directly. What do you think ? I couldn't find any info on the issue regarding that topic.

Screen.Recording.2024-06-14.at.16.20.15.mov

Thanks!

@tblivet tblivet dismissed stale reviews from boherm and nicosomb via 554d043 June 17, 2024 08:50
@tblivet
Copy link
Contributor Author

tblivet commented Jun 17, 2024

Hi @florine2623,

Thank you for the QA !

Bug 1: I have noticed the bug you reported. However, I think this can be fixed outside this PR to address the problem globally if other links in the theme use scroll anchors.

Bug 2: You're right 👍 the "Write your review" button should open the modal directly, so I have made a new commit to correct it.

@ps-jarvis
Copy link

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

  • Shop.Theme.Catalog
    • Products pagination

(Note: this is an automated message, but answering it will reach a real human)

Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet ,

BUG 2 is fixed ^^ ✅
Thanks!

@tblivet tblivet merged commit 1d6a9e8 into PrestaShop:develop Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[UNFINISHED THINGS] - Sytle product comment
5 participants