Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format availability for the new style #658

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Oct 31, 2024

Questions Answers
Description? Adapts the template to display availability in a new way. No CSS used, simple boostrap alert is used.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test?

Related core PRs

How it looks

In stock
stock

Available on backorder
available_backorder

Not available (+ a new availability submessage)
not available

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 6, 2024

@florine2623 This can be tested standalone, the availability_subtext is optional.

@florine2623 florine2623 self-assigned this Nov 13, 2024
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox ,

I have a rebase going on when I install this PR.
Am I missing something ?

Screenshot 2024-11-13 at 10 54 46

Waiting for your feedback ^^
Thanks!

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 13, 2024

@florine2623 No idea, but the core doesn't have anything to do with this PR. :-) I suggest using a built version of hummingbird and just changing the one file manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

5 participants