Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update button style for new brand #244

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Update button style for new brand #244

merged 1 commit into from
Dec 29, 2023

Conversation

M0rgan01
Copy link

@M0rgan01 M0rgan01 commented Dec 29, 2023 •
edited
Loading

Questions Answers
Description? Update button style for new brand
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #PrestaShop/PrestaShop#34900
Linked PR PrestaShop/ps-org-theme#13
Sponsor company -
How to test? -

The new buttons have a new class, to avoid conflicts with those of bootstrap, like on prestashop.com. See PrestaShop/ps-org-theme#13

@M0rgan01 M0rgan01 mentioned this pull request Dec 29, 2023
Merged
matks
matks approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@matks matks merged commit 77eb860 into PrestaShop:master Dec 29, 2023
1 check passed
@matks
Copy link
Contributor

matks commented Dec 29, 2023

Thank you @M0rgan01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@matks matks matks approved these changes

@tleon tleon tleon approved these changes

@mflasquin mflasquin mflasquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@M0rgan01 @matks @matthieu-rolland @tleon @mflasquin @kpodemski