Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a create a version branch doc #275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tleon
Copy link

@tleon tleon commented Oct 22, 2024

Questions Answers
Description Create a new doc for creating a branch version.
Fixed ticket Fixes #37139

@tleon tleon self-assigned this Oct 22, 2024
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't put PRs in the doc. I have made multiple PRs for fixing missing things in project.

@tleon tleon force-pushed the add-new-doc-for-version-branch-creation branch from 259afe8 to 9222163 Compare October 24, 2024 09:42
@tleon tleon requested a review from Progi1984 October 24, 2024 09:42
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggestions @tleon


## 1) Create the new branch and push it to the main repo

## 2) Open PRs based on the new branch and modify those files :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 2) Open PRs based on the new branch and modify those files :
## 2) Open PRs based on the new branch and modify those files:


## 2) Open PRs based on the new branch and modify those files :

There are multiples repo to update.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are multiples repo to update.
To create the new branch, we need to update several repositories to complete the necessary work.


There are multiples repo to update.

We'll list the file we modified for the creation of the 9.0.x branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We'll list the file we modified for the creation of the 9.0.x branch.
Below is a list of repositories with modified files for creating the `9.0.x` branch.

Comment on lines +18 to +19

Changed files :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Changed files :


Changed files :

PrestaShop/PrestaShop :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PrestaShop/PrestaShop :
`PrestaShop/PrestaShop`:

- src/App/Command/SlackNotifierCommand.php


PrestaShop/prestashop.github.io : ( no PR needed this time )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PrestaShop/prestashop.github.io : ( no PR needed this time )
`PrestaShop/prestashop.github.io`: (you can commit the changes directly, no need to create a pull request)


PrestaShop/prestashop.github.io : ( no PR needed this time )

- data/tags.yml ( check if already updated )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- data/tags.yml ( check if already updated )
- data/tags.yml (make sure the tag doesn't exists already)


- data/tags.yml ( check if already updated )

PrestaShop/kanbanbot :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PrestaShop/kanbanbot :
`PrestaShop/kanbanbot`:

- tests/Shared/Infrastructure/Provider/TranslationsCatalogProviderTest.php
- tests/PullRequest/Application/CommandHandler/CheckTableDescriptionCommandHandlerTest.php

The following repo should be updated by the QA autom team but anyway here are the files we updated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following repo should be updated by the QA autom team but anyway here are the files we updated.
The QA Automation Team should update the following repositories:


The following repo should be updated by the QA autom team but anyway here are the files we updated.

PrestaShop/ga.tests.ui.pr :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PrestaShop/ga.tests.ui.pr :
`PrestaShop/ga.tests.ui.pr`:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To be tested
Development

Successfully merging this pull request may close these issues.

5 participants