Improve shop creator with php-cs-fixer #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mflasquin
commented
Nov 2, 2022
•
mflasquin
commented
| Questions | Answers |
|---|---|
| Description? | Improve shop creator with setup of github workflow and add php-cs-fixer |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #23 |
| How to test? | see mflasquin#1 |
| Possible impacts? | Please indicate what parts of the software we need to check to make sure everything is alright. |
|
POC pipeline : mflasquin#1 |
mflasquin
force-pushed
the
improve/23-php-cs-fixer
branch
from
41b416e to
9d825e9
Compare
mflasquin
force-pushed
the
improve/23-php-cs-fixer
branch
from
9d825e9 to
708953d
Compare
|
Hi @matks, this PR is also rebased 😄 so if you want to take a look you're welcome |
matks
approved these changes
Nov 10, 2022
|
Thank you @mflasquin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.