Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the stock field behavior on the product page #160

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Change the stock field behavior on the product page #160

wants to merge 8 commits into from

Conversation

MatShir
Copy link
Contributor

@MatShir MatShir commented Oct 22, 2020

Questions Answers
Description? To avoid inconsistency when editing the product stock. A warning will be displayed on the top of the input: "We advise you to modify the quantity directly in the [1]Catalog > Stocks[/1] section of the back office to avoid stock imbalance." in Admin.Notifications.Warning. The link redirects to the stock page on another tab with the product displayed/loaded. In the basic tab, change the input into a text (semibold) to only display the quantity
Fixed ticket? PrestaShop/PrestaShop#19454

@MatShir
Copy link
Contributor Author

MatShir commented Oct 22, 2020

I apologize in advance, the differences for the review are behaving strangely

@MatShir MatShir added Review required Specifications to be reviewed Waiting for PM Waiting for PM review Waiting for QA Waiting for QA review labels Oct 22, 2020
marionf
marionf reviewed Oct 27, 2020
View reviewed changes
back-office/catalog/products/catalog-products-add-edit.md
@@ -213,6 +224,11 @@ Here is the list of the elements of quantities tab:
When you update the field in quantities tab, the same field in basic settings tab is updated.
The quantity is displayed in front-office if the option “Display available quantities on the product page” in Shop parameters > Product settings is set to yes.
This value is decremented when an order is placed except if the order status is Payement error. This value is incremented when the order status is cancelled, when you make a partial refund and check “Re-stock products” and when you return products and check “Re-stock products”.

On top of the quantity input, the page has the following wording (new wording integrated by the issue #19454):
"We advise you to modify the quantity directly in the [1]Catalog > Stocks[/1] section of the back office to avoid stock imbalance." in Admin.Notifications.Warning.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add this message also in the virtual product & combinations tabs ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right for the Pack and Virtual product. I'm going to see for the combinations tabs. Thanks

@marionf marionf added Waiting for author Waiting for author feedback and removed Waiting for PM Waiting for PM review labels Oct 27, 2020
@LouiseBonnard
Copy link
Contributor

Hi @MatShir, what's the status of this specification? Do you still need a PM review?

@MatShir MatShir added WIP Work in progress and removed Review required Specifications to be reviewed Waiting for QA Waiting for QA review Waiting for author Waiting for author feedback labels Nov 2, 2020
@MatShir
Copy link
Contributor Author

MatShir commented Nov 2, 2020 •
edited
Loading

Back to WIP, few things need to be added (check the behavior for the different product type)

@MatShir MatShir changed the title Update catalog-products-add-edit.md Change the stock field behavior on the product page Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marionf marionf marionf left review comments

@LouiseBonnard LouiseBonnard LouiseBonnard left review comments

@Robin-Fischer-PS Robin-Fischer-PS Awaiting requested review from Robin-Fischer-PS

Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatShir @LouiseBonnard @marionf