Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the shipping method for virtual product when the order summary is enabled #209

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Hide the shipping method for virtual product when the order summary is enabled #209

wants to merge 9 commits into from

Conversation

MatShir
Copy link
Contributor

@MatShir MatShir commented Mar 4, 2021

Questions Answers
Description? Hide the shipping method for virtual product when the order summary is enabled
Fixed ticket? PrestaShop/PrestaShop#8738

@MatShir MatShir added Review required Specifications to be reviewed Waiting for PM Waiting for PM review Waiting for QA Waiting for QA review labels Mar 4, 2021
@MatShir MatShir mentioned this pull request Mar 4, 2021
Merged
Robin-Fischer-PS
Robin-Fischer-PS reviewed Mar 10, 2021
View reviewed changes
Copy link
Contributor

@Robin-Fischer-PS Robin-Fischer-PS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, otherwise LGTM.

front-office/checkout.md Outdated Show resolved Hide resolved
front-office/checkout.md Outdated Show resolved Hide resolved
@Robin-Fischer-PS Robin-Fischer-PS added Waiting for author Waiting for author feedback and removed Waiting for QA Waiting for QA review labels Mar 10, 2021
marionf
marionf suggested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@marionf marionf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments @MatShir

front-office/checkout.md Outdated Show resolved Hide resolved
front-office/checkout.md Outdated Show resolved Hide resolved
front-office/checkout.md Outdated Show resolved Hide resolved
front-office/checkout.md Outdated Show resolved Hide resolved
@marionf marionf removed Review required Specifications to be reviewed Waiting for PM Waiting for PM review labels Mar 11, 2021
@MatShir MatShir added Review required Specifications to be reviewed and removed Waiting for author Waiting for author feedback labels Apr 29, 2021
@marionf
Copy link
Contributor

marionf commented Apr 29, 2021

@MatShir Could you fix the conflict ?

@marionf marionf added Waiting for author Waiting for author feedback and removed Review required Specifications to be reviewed labels Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robin-Fischer-PS Robin-Fischer-PS Robin-Fischer-PS left review comments

@marionf marionf marionf approved these changes

Assignees
No one assigned
Labels
Waiting for author Waiting for author feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatShir @marionf @Robin-Fischer-PS