Add tests for the feedback feature

app/config/services_test.yml

@@ -32,6 +32,12 @@ services:
     # Integration tests shouldn't post comments to github
     Psr\Log\NullLogger:
 
+    Tests\AppBundle\Search\FakeRepository:
+        decorates: AppBundle\Search\RepositoryInterface
+
+    Tests\AppBundle\Organisations\FakeRepository:
+        - ['%repository_username%']
+
     Tests\AppBundle\Comments\FakeCommentApi:
         - '@Github\Api\Issue\Comments'
         - '%repository_username%'
@@ -53,7 +59,7 @@ services:
             - '@Tests\AppBundle\Commits\FakeRepository'
             - '@validator'
             - '@AppBundle\PullRequests\Repository'
-            - '@AppBundle\Organizations\Repository'
+            - '@Tests\AppBundle\Organisations\FakeRepository'
             - '@Psr\Log\NullLogger'
 
     AppBundle\Issues\Listener:

src/AppBundle/Organizations/Repository.php

@@ -5,7 +5,7 @@
 use Github\Api\Organization;
 use Github\Exception\RuntimeException;
 
-class Repository
+class Repository implements RepositoryInterface
 {
     /**
      * @var array list of teams (won't change during a request)
@@ -28,7 +28,7 @@ public function __construct(Organization $organizationApi, $repositoryOwner)
     }
 
     /**
-     * @return array
+     * {@inheritdoc}
      */
     public function getTeams()
     {
@@ -48,7 +48,7 @@ public function getTeams()
     }
 
     /**
-     * @param string $teamName
+     * {@inheritdoc}
      */
     public function getTeam(string $teamName)
     {
@@ -58,9 +58,7 @@ public function getTeam(string $teamName)
     }
 
     /**
-     * @param string $teamName
-     *
-     * @return \Guzzle\Http\EntityBodyInterface|mixed|string
+     * {@inheritdoc}
      */
     public function getTeamMembers(string $teamName)
     {
@@ -77,11 +75,7 @@ public function getTeamMembers(string $teamName)
     }
 
     /**
-     * Check if a user is a member of the organisation.
-     *
-     * @param string $userLogin
-     *
-     * @return bool
+     * {@inheritdoc}
      */
     public function isMember(string $userLogin)
     {

src/AppBundle/Organizations/RepositoryInterface.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace AppBundle\Organizations;
+
+interface RepositoryInterface
+{
+    /**
+     * @return array
+     */
+    public function getTeams();
+
+    /**
+     * @param string $teamName
+     */
+    public function getTeam(string $teamName);
+
+    /**
+     * @param string $teamName
+     *
+     * @return \Guzzle\Http\EntityBodyInterface|mixed|string
+     */
+    public function getTeamMembers(string $teamName);
+
+    /**
+     * Check if a user is a member of the organisation.
+     *
+     * @param string $userLogin
+     *
+     * @return bool
+     */
+    public function isMember(string $userLogin);
+}

src/AppBundle/PullRequests/Listener.php

@@ -4,7 +4,7 @@
 
 use AppBundle\Comments\CommentApiInterface;
 use AppBundle\Commits\RepositoryInterface as CommitRepositoryInterface;
-use AppBundle\Organizations\Repository as OrganizationRepository;
+use AppBundle\Organizations\RepositoryInterface as OrganizationRepository;
 use AppBundle\PullRequests\RepositoryInterface as PullRequestRepositoryInterface;
 use DateInterval;
 use DateTime;

src/AppBundle/PullRequests/Repository.php

@@ -2,7 +2,7 @@
 
 namespace AppBundle\PullRequests;
 
-use AppBundle\Search\Repository as SearchRepository;
+use AppBundle\Search\RepositoryInterface as SearchRepository;
 use DateInterval;
 use DateTime;
 use Github\Api\Issue\Comments as KnpCommentsApi;

src/AppBundle/Search/Repository.php

@@ -10,7 +10,7 @@
  *
  * @doc https://github.com/KnpLabs/php-github-api/blob/master/doc/search.md
  */
-class Repository
+class Repository implements RepositoryInterface
 {
     /**
      * @var Search
@@ -38,9 +38,7 @@ public function __construct(Search $searchApi, GraphQL $graphQL, string $reposit
     }
 
     /**
-     * @param array $filters
-     *
-     * @return array
+     * {@inheritdoc}
      */
     public function getPullRequests($filters = []): array
     {
@@ -56,10 +54,7 @@ public function getPullRequests($filters = []): array
     }
 
     /**
-     * @param $query
-     * @param array $variables
-     *
-     * @return array
+     * {@inheritdoc}
      */
     public function graphQL($query, $variables = []): array
     {

src/AppBundle/Search/RepositoryInterface.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace AppBundle\Search;
+
+interface RepositoryInterface
+{
+    /**
+     * @param array $filters
+     *
+     * @return array
+     */
+    public function getPullRequests($filters = []): array;
+
+    /**
+     * @param $query
+     * @param array $variables
+     *
+     * @return array
+     */
+    public function graphQL($query, $variables = []): array;
+}

tests/AppBundle/Controller/WebhookControllerTest.php

@@ -147,6 +147,26 @@ public function getTests()
                 ],*/
             ],
         ];
+        $tests['Pull request from community merged'] = [
+            'pull_request',
+            'pull_request_community_merged.json',
+            [
+                [
+                    'event' => 'pr_merged',
+                    'action' => 'ask for feedback',
+                ],
+            ],
+        ];
+        $tests['Pull request from community merged less that 30 days ago'] = [
+            'pull_request',
+            'pull_request_community_merged_30days_ago.json',
+            [],
+        ];
+        $tests['Pull request from ps organisation merged'] = [
+            'pull_request',
+            'pull_request_organisation_merged.json',
+            [],
+        ];
         $tests['Pull request creation for critical bug'] = [
             'issues',
             'issues.labeled.bug.json',

tests/AppBundle/Organisations/FakeRepository.php

@@ -0,0 +1,35 @@
+<?php
+
+namespace Tests\AppBundle\Organisations;
+
+use AppBundle\Organizations\RepositoryInterface;
+
+class FakeRepository implements RepositoryInterface
+{
+    private $members;
+
+    public function __construct($members = [])
+    {
+        $this->members = $members;
+    }
+
+    public function getTeams()
+    {
+        // TODO: Implement getTeams() method.
+    }
+
+    public function getTeam(string $teamName)
+    {
+        // TODO: Implement getTeam() method.
+    }
+
+    public function getTeamMembers(string $teamName)
+    {
+        // TODO: Implement getTeamMembers() method.
+    }
+
+    public function isMember(string $userLogin)
+    {
+        return \in_array($userLogin, $this->members, true);
+    }
+}