This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
Update dependencies, including Symfony 3 to 4 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jolelievre
commented
Jul 3, 2023
jolelievre
commented
| Questions | Answers |
|---|---|
| Description? | Update dependencies |
| Type? | improvement |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed ticket? | ~ |
| Sponsor company | ~ |
| How to test? | ~ |
Removed old entry on .dockerignore
M0rgan01
approved these changes
Jul 3, 2023
boherm
approved these changes
Jul 4, 2023
tleon
approved these changes
Jul 4, 2023
matks
changed the title
| $environment->registerUndefinedFilterCallback(function ($name) { | ||
| return new TwigFilter($name, [$this, 'doNothing']); | ||
| }); | ||
| $environment->registerUndefinedFunctionCallback(function () {}); |
There was a problem hiding this comment.
I'm impressed if one of you knows can tell me why we do this.
But if you knows, don't be like me : document it 🙂
|
I'm happy to see my old baby still maintained, thanks @jolelievre and good job ofc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.