Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manual lang process by standard DoctrineRelation and SymfonyFormData #191

Conversation

leemyongpakvn
Copy link
Contributor

Questions Answers
Description? Replace manual lang field process for Criterion by standard Doctrine relation.
Migrate some legacy functions to standard Symfony FormData Provider and Handler.
Type? refacto
BC breaks? no
Deprecations? yes
Fixed ticket? PrestaShop/PrestaShop/discussions/34472
How to test? 1. Apply this PR changes.
2. In FO: clear browser cache & In BO: Performance > clear cache (required as there are 2 new-added services).
3. Check all module features in both FO and BO to make sure they work as usual, especially multilingual feature for criterion name.

@leemyongpakvn leemyongpakvn changed the title Migrate manual lang process by standard doctrine n s fform data Migrate manual lang process by standard DoctrineRelation and SymfonyFormData Dec 9, 2023
@leemyongpakvn leemyongpakvn added this to the 6.0.3 milestone Dec 9, 2023
@leemyongpakvn leemyongpakvn changed the title Migrate manual lang process by standard DoctrineRelation and SymfonyFormData Replace manual lang process by standard DoctrineRelation and SymfonyFormData Dec 10, 2023
@AureRita
Copy link

AureRita commented Dec 29, 2023

Hi @leemyongpakvn

Thank you for your PR, all seems to works except the quick enable/disable of a parameters, as you can see at the end of this video :

recording.30.webm

Thank you

@leemyongpakvn
Copy link
Contributor Author

leemyongpakvn commented Dec 31, 2023

@AureRita Did you mean Default status of Active in New Criterion form ? It is Enable before this PR, and Disable after this PR.
Update: I see what you meant now. I also saw the same issue with early version of this PR but it was fixed with last commit on Dec 14 2023. I have just tested again by git clone current dev branch and gh pr checkout 191 and don't see that issue any more. Please test again and make sure you clear both caches.

@paulnoelcholot
Copy link

Hello @leemyongpakvn,

I tested your PR and it's good for me! 🎉

Thanks!

@nicosomb nicosomb merged commit a46ac63 into PrestaShop:dev Jan 9, 2024
8 checks passed
@nicosomb
Copy link
Contributor

nicosomb commented Jan 9, 2024

Thank you @leemyongpakvn !

@florine2623 florine2623 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants